[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220818163527.GB1978870-robh@kernel.org>
Date: Thu, 18 Aug 2022 10:35:27 -0600
From: Rob Herring <robh@...nel.org>
To: wei.fang@....com
Cc: andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, krzysztof.kozlowski+dt@...aro.org,
f.fainelli@...il.com, netdev@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 net 1/2] dt-bindings: net: ar803x: add
disable-hibernation-mode propetry
On Thu, Aug 18, 2022 at 11:00:53AM +0800, wei.fang@....com wrote:
> From: Wei Fang <wei.fang@....com>
>
> The hibernation mode of Atheros AR803x PHYs defaults to be
> enabled after hardware reset. When the cable is unplugged,
> the PHY will enter hibernation mode after about 10 seconds
> and the PHY clocks will be stopped to save power.
> However, some MACs need the phy output clock for proper
> functioning of their logic. For instance, stmmac needs the
> RX_CLK of PHY for software reset to complete.
> Therefore, add a DT property to configure the PHY to disable
> this hardware hibernation mode.
>
> Signed-off-by: Wei Fang <wei.fang@....com>
> ---
> V2 change:
> 1. Add subject prefix.
> 2. Modify the property name and description to make them clear.
> V3 change:
> According to Andrew's suggestion, remodify the description to
> make it clear.
> ---
> Documentation/devicetree/bindings/net/qca,ar803x.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
Reviewed-by: Rob Herring <robh@...nel.org>
Powered by blists - more mailing lists