linux-kernel - Re: [PATCH v9 02/27] kallsyms: avoid hardcoding buffer size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220818165025.ighwic3zqe2xh6be@gpm.stappers.nl>
Date:   Thu, 18 Aug 2022 18:50:26 +0200
From:   Geert Stappers <stappers@...ppers.nl>
To:     Kees Cook <keescook@...omium.org>, Miguel Ojeda <ojeda@...nel.org>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, patches@...ts.linux.dev,
        Jarkko Sakkinen <jarkko@...nel.org>,
        Boqun Feng <boqun.feng@...il.com>
Subject: Re: [PATCH v9 02/27] kallsyms: avoid hardcoding buffer size

On Wed, Aug 17, 2022 at 12:37:40PM -0700, Kees Cook wrote:
> On Fri, Aug 05, 2022 at 05:41:47PM +0200, Miguel Ojeda wrote:
> > From: Boqun Feng <boqun.feng@...il.com>
> > 
> > This introduces `KSYM_NAME_LEN_BUFFER` in place of the previously
> > hardcoded size of the input buffer.
> > 
> > It will also make it easier to update the size in a single place
> > in a later patch.
> > 
> > Signed-off-by: Boqun Feng <boqun.feng@...il.com>
> > Co-developed-by: Miguel Ojeda <ojeda@...nel.org>
> > Signed-off-by: Miguel Ojeda <ojeda@...nel.org>
> 
> Reviewed-by: Kees Cook <keescook@...omium.org>
> 
> Does someone want to commit to taking these "prereq" patches? These
> clean-ups are nice even without adding Rust.

Qouting Message-ID: <CANiq72mXDne_WkUCo2oRe+sip7nQWESnouOJrcCYzyJMkG8F6A@...l.gmail.com>
https://lore.kernel.org/lkml/CANiq72mXDne_WkUCo2oRe+sip7nQWESnouOJrcCYzyJMkG8F6A@mail.gmail.com/
Miguel Ojeda, 2022-08-05: 
| > And I think that this patch and all other "rust" kallsyms patches
| > allready should have been accepted in the v3 or v5 series.
| 
| Yeah, it could be a good idea to get the prerequisites in first.
| Let's see if the patches get some Reviewed-bys

Now that there is a 'Reviewed-by: Kees Cook <keescook@...omium.org>'


Regards
Geert Stappers
In an attempt to help making Rust for Linux happen.
-- 
Silence is hard to parse