linux-kernel - Re: [PATCH net-next] net: sched: remove duplicate check of user rights in qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220818204408.3fcb12a0@kernel.org>
Date:   Thu, 18 Aug 2022 20:44:08 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Zhengchao Shao <shaozhengchao@...wei.com>
Cc:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <jhs@...atatu.com>, <xiyou.wangcong@...il.com>, <jiri@...nulli.us>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
        <weiyongjun1@...wei.com>, <yuehaibing@...wei.com>
Subject: Re: [PATCH net-next] net: sched: remove duplicate check of user
 rights in qdisc

On Thu, 18 Aug 2022 15:25:00 +0800 Zhengchao Shao wrote:
> -	if ((n->nlmsg_type != RTM_GETACTION) &&
> -	    !netlink_capable(skb, CAP_NET_ADMIN))
> -		return -EPERM;

This check is not network namespace capable, right?

We're probably fine making it namespace aware but it needs to be a
separate change.