linux-kernel - Re: [RFC 0/2] Stop the abuse of Linux-*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57cf9b61-82f4-f6d4-7f43-c3f94de7aaf3@amd.com>
Date:   Fri, 19 Aug 2022 11:00:21 -0500
From:   "Limonciello, Mario" <mario.limonciello@....com>
To:     Karol Herbst <kherbst@...hat.com>, Lyude Paul <lyude@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
        rafael@...nel.org, Len Brown <lenb@...nel.org>,
        nouveau@...ts.freedesktop.org, hdegoede@...hat.com,
        ddadap@...dia.com, kai.heng.feng@...onical.com,
        Dell.Client.Kernel@...l.com
Subject: Re: [RFC 0/2] Stop the abuse of Linux-* _OSI strings

On 8/19/2022 10:44, Karol Herbst wrote:
> On Fri, Aug 19, 2022 at 4:25 PM Mario Limonciello
> <mario.limonciello@....com> wrote:
>>
>> 3 _OSI strings were introduced in recent years that were intended
>> to workaround very specific problems found on specific systems.
>>
>> The idea was supposed to be that these quirks were only used on
>> those systems, but this proved to be a bad assumption.  I've found
>> at least one system in the wild where the vendor using the _OSI
>> string doesn't match the _OSI string and the neither does the use.
>>
>> So this brings a good time to review keeping those strings in the kernel.
>> There are 3 strings that were introduced:
>>
>> Linux-Dell-Video
>> -> Intended for systems with NVIDIA cards that didn't support RTD3
>> Linux-Lenovo-NV-HDMI-Audio
>> -> Intended for powering on NVIDIA HDMI device
>> Linux-HPI-Hybrid-Graphics
>> -> Intended for changing dGPU output
>>
>> AFAIK the first string is no longer relevant as nouveau now supports
>> RTD3.  If that's wrong, this can be changed for the series.
>>
> 
> Nouveau always supported RTD3, because that's mainly a kernel feature.
> When those were introduced we simply had a bug only hit on a few
> systems. And instead of helping us to debug this, this workaround was
> added :( We were not even asked about this.

My apologies, I was certainly part of the impetus for this W/A in the 
first place while I was at my previous employer.  Your comment 
re-affirms to me that at least the first patch is correct.

> 
> I am a bit curious about the other two though as I am not even sure
> they are needed at all as we put other work arounds in place. @Lyude
> Paul might know more about these.
> 

If the other two really aren't needed anymore, then yeah we should just 
tear all 3 out.  If that's the direction we go, I would appreciate some 
commit IDs to reference in the commit message for tearing them out so 
that if they end up backporting to stable we know how far they should go.