[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20220819002905.82095-1-dakr@redhat.com>
Date: Fri, 19 Aug 2022 02:29:02 +0200
From: Danilo Krummrich <dakr@...hat.com>
To: daniel@...ll.ch, airlied@...ux.ie, tzimmermann@...e.de,
mripard@...nel.org
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
Danilo Krummrich <dakr@...hat.com>
Subject: [PATCH drm-misc-next 0/3] Fixes for vc4 hotplug rework
Hi,
I've found a few potential issues left after the hotplug rework.
In vc4_hdmi.c we're missing two mutex_unlock() calls when the device is
unplugged.
vc4_crtc and vc4_plane seem to miss some drm_dev_enter()/drm_dev_exit() calls
to protect against resource access after the device/driver is unbound, but the
DRM potentially isn't freed yet and userspace can still call into the driver.
Danilo Krummrich (3):
drm/vc4: hdmi: unlock mutex when device is unplugged
drm/vc4: plane: protect device resources after removal
drm/vc4: crtc: protect device resources after removal
drivers/gpu/drm/vc4/vc4_crtc.c | 41 ++++++++++++++++++++++++++++++++-
drivers/gpu/drm/vc4/vc4_drv.h | 1 +
drivers/gpu/drm/vc4/vc4_hdmi.c | 7 ++++--
drivers/gpu/drm/vc4/vc4_plane.c | 25 ++++++++++++++++++++
4 files changed, 71 insertions(+), 3 deletions(-)
base-commit: 8ba9249396bef37cb68be9e8dee7847f1737db9d
--
2.37.2
Powered by blists - more mailing lists