lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 19 Aug 2022 04:46:56 +0000 From: Vishnu Dasa <vdasa@...are.com> To: Stefano Garzarella <sgarzare@...hat.com> CC: Arseniy Krasnov <AVKrasnov@...rdevices.ru>, Bryan Tan <bryantan@...are.com>, Pv-drivers <Pv-drivers@...are.com>, "David S. Miller" <davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "kys@...rosoft.com" <kys@...rosoft.com>, "haiyangz@...rosoft.com" <haiyangz@...rosoft.com>, "sthemmin@...rosoft.com" <sthemmin@...rosoft.com>, "wei.liu@...nel.org" <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>, Stefan Hajnoczi <stefanha@...hat.com>, Krasnov Arseniy <oxffffaa@...il.com>, "virtualization@...ts.linux-foundation.org" <virtualization@...ts.linux-foundation.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>, kernel <kernel@...rdevices.ru> Subject: Re: [RFC PATCH v3 8/9] vmci/vsock: check SO_RCVLOWAT before wake up reader > On Aug 8, 2022, at 4:01 AM, Stefano Garzarella <sgarzare@...hat.com> wrote: > > On Wed, Aug 03, 2022 at 02:05:52PM +0000, Arseniy Krasnov wrote: >> This adds extra condition to wake up data reader: do it only when number >> of readable bytes >= SO_RCVLOWAT. Otherwise, there is no sense to kick >> user,because it will wait until SO_RCVLOWAT bytes will be dequeued. Nit: add space after comma. > Ditto as previous patch. > > @Bryan, @Vishnu, plaese, can you review/ack also this patch? This patch looks good to me. Thank you, Arseniy for running the new test with VMCI. I also ran some of our internal tests successfully with this patch series. > Thanks, > Stefano > >> >> Signed-off-by: Arseniy Krasnov <AVKrasnov@...rdevices.ru> Reviewed-by: Vishnu Dasa <vdasa@...are.com> >> --- >> net/vmw_vsock/vmci_transport_notify.c | 2 +- >> net/vmw_vsock/vmci_transport_notify_qstate.c | 4 ++-- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/net/vmw_vsock/vmci_transport_notify.c b/net/vmw_vsock/vmci_transport_notify.c >> index 852097e2b9e6..7c3a7db134b2 100644 >> --- a/net/vmw_vsock/vmci_transport_notify.c >> +++ b/net/vmw_vsock/vmci_transport_notify.c >> @@ -307,7 +307,7 @@ vmci_transport_handle_wrote(struct sock *sk, >> struct vsock_sock *vsk = vsock_sk(sk); >> PKT_FIELD(vsk, sent_waiting_read) = false; >> #endif >> - sk->sk_data_ready(sk); >> + vsock_data_ready(sk); >> } >> >> static void vmci_transport_notify_pkt_socket_init(struct sock *sk) >> diff --git a/net/vmw_vsock/vmci_transport_notify_qstate.c b/net/vmw_vsock/vmci_transport_notify_qstate.c >> index 12f0cb8fe998..e96a88d850a8 100644 >> --- a/net/vmw_vsock/vmci_transport_notify_qstate.c >> +++ b/net/vmw_vsock/vmci_transport_notify_qstate.c >> @@ -84,7 +84,7 @@ vmci_transport_handle_wrote(struct sock *sk, >> bool bottom_half, >> struct sockaddr_vm *dst, struct sockaddr_vm *src) >> { >> - sk->sk_data_ready(sk); >> + vsock_data_ready(sk); >> } >> >> static void vsock_block_update_write_window(struct sock *sk) >> @@ -282,7 +282,7 @@ vmci_transport_notify_pkt_recv_post_dequeue( >> /* See the comment in >> * vmci_transport_notify_pkt_send_post_enqueue(). >> */ >> - sk->sk_data_ready(sk); >> + vsock_data_ready(sk); >> } >> >> return err; >> -- >> 2.25.1
Powered by blists - more mailing lists