linux-kernel - Re: [PATCH v3] kbuild: add debug level and macro defs options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOdnnSAozX8bQ9HeSw12BV9OjpzyDmXk_BGczjVVQNN+7tQ@mail.gmail.com>
Date:   Fri, 19 Aug 2022 10:42:06 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Dmitrii Bundin <dmitrii.bundin.a@...il.com>
Cc:     masahiroy@...nel.org, akpm@...ux-foundation.org,
        dan.j.williams@...el.com, edumazet@...gle.com,
        isabbasso@...eup.net, jpoimboe@...nel.org, keescook@...omium.org,
        linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux@...musvillemoes.dk, maskray@...gle.com,
        michal.lkml@...kovi.net, nathan@...nel.org, peterz@...radead.org,
        vbabka@...e.cz
Subject: Re: [PATCH v3] kbuild: add debug level and macro defs options

On Sun, Aug 14, 2022 at 6:34 PM Dmitrii Bundin
<dmitrii.bundin.a@...il.com> wrote:
>
> Adds config options to control debug info level and producing of macro
> definitions for GCC/Clang.
>
> Option DEBUG_INFO_LEVEL is responsible for controlling debug info level.
> Before GCC 11 and Clang 12 -gsplit-dwarf implicitly uses -g2. To provide
> a way to override the setting with, e.g. -g1, DEBUG_INFO_LEVEL is set
> independently from DEBUG_INFO_SPLIT.
>
> Option DEBUG_MACRO_DEFINITIONS is responsible for controlling inclusion
> of macro definitions. Since Clang uses -fdebug-macro to control if macro
> definitions are produced which is different from GCC, provides a
> compiler-specific way of handling macro inclusion. The option is handled
> after DEBUG_INFO_LEVEL since -g3 -g2 implies -g2, but -g2 -g3 implies
> -g3 and GCC uses -g3 to produce macro definitions.
>
> Signed-off-by: Dmitrii Bundin <dmitrii.bundin.a@...il.com>
> ---
>
> Changes in v2: https://lore.kernel.org/all/20220804223504.4739-1-dmitrii.bundin.a@gmail.com/

Is any of this really necessary?  It seems like a great way to bloat
vmlinux artifacts built with CONFIG_DEBUG_INFO even further.  The
above link mentions "when debugging with GDB."  In that case, please
don't add new Kconfigs for these; just set -g3 when
CONFIG_GDB_SCRIPTS=y.

-- 
Thanks,
~Nick Desaulniers