| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 20 Aug 2022 02:17:14 +0800
From: kernel test robot <lkp@...el.com>
To: Jiri Pirko <jiri@...dia.com>
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
linux-kernel@...r.kernel.org
Subject: [jpirko-mlxsw:jiri_devel_devlink_locking 5/42]
drivers/net/wwan/t7xx/t7xx_port_devlink.c:465:35: error: use of undeclared
identifier 'DEVLINK_SUPPORT_FLASH_UPDATE_COMPONENT'; did you mean
'DEVLINK_ATTR_FLASH_UPDATE_COMPONENT'?
drivers/net/netdevsim/dev.c
include/net/devlink.h
net/core/devlink.c
tree: https://github.com/jpirko/linux_mlxsw jiri_devel_devlink_locking
head: e7096f2b22b32bd60568d91d12b562b3314bc8cc
commit: d8cf683bc939bf07c19efa964a98f10829e30df4 [5/42] net: devlink: extend info_get() version put to indicate a flash component
config: s390-randconfig-r044-20220819 (https://download.01.org/0day-ci/archive/20220820/202208200242.iM0kVtBs-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 0ac597f3cacf60479ffd36b03766fa7462dabd78)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install s390 cross compiling tool for clang build
# apt-get install binutils-s390x-linux-gnu
# https://github.com/jpirko/linux_mlxsw/commit/d8cf683bc939bf07c19efa964a98f10829e30df4
git remote add jpirko-mlxsw https://github.com/jpirko/linux_mlxsw
git fetch --no-tags jpirko-mlxsw jiri_devel_devlink_locking
git checkout d8cf683bc939bf07c19efa964a98f10829e30df4
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/net/ethernet/mellanox/mlx5/core/ drivers/net/wwan/t7xx/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
In file included from drivers/net/wwan/t7xx/t7xx_port_devlink.c:10:
In file included from drivers/net/wwan/t7xx/t7xx_hif_cldma.h:23:
In file included from include/linux/dmapool.h:14:
In file included from include/linux/scatterlist.h:9:
In file included from arch/s390/include/asm/io.h:75:
include/asm-generic/io.h:547:31: error: performing pointer arithmetic on a null pointer has undefined behavior [-Werror,-Wnull-pointer-arithmetic]
val = __raw_readb(PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:560:61: error: performing pointer arithmetic on a null pointer has undefined behavior [-Werror,-Wnull-pointer-arithmetic]
val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:37:59: note: expanded from macro '__le16_to_cpu'
#define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x))
^
include/uapi/linux/swab.h:102:54: note: expanded from macro '__swab16'
#define __swab16(x) (__u16)__builtin_bswap16((__u16)(x))
^
In file included from drivers/net/wwan/t7xx/t7xx_port_devlink.c:10:
In file included from drivers/net/wwan/t7xx/t7xx_hif_cldma.h:23:
In file included from include/linux/dmapool.h:14:
In file included from include/linux/scatterlist.h:9:
In file included from arch/s390/include/asm/io.h:75:
include/asm-generic/io.h:573:61: error: performing pointer arithmetic on a null pointer has undefined behavior [-Werror,-Wnull-pointer-arithmetic]
val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
~~~~~~~~~~ ^
include/uapi/linux/byteorder/big_endian.h:35:59: note: expanded from macro '__le32_to_cpu'
#define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x))
^
include/uapi/linux/swab.h:115:54: note: expanded from macro '__swab32'
#define __swab32(x) (__u32)__builtin_bswap32((__u32)(x))
^
In file included from drivers/net/wwan/t7xx/t7xx_port_devlink.c:10:
In file included from drivers/net/wwan/t7xx/t7xx_hif_cldma.h:23:
In file included from include/linux/dmapool.h:14:
In file included from include/linux/scatterlist.h:9:
In file included from arch/s390/include/asm/io.h:75:
include/asm-generic/io.h:584:33: error: performing pointer arithmetic on a null pointer has undefined behavior [-Werror,-Wnull-pointer-arithmetic]
__raw_writeb(value, PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:594:59: error: performing pointer arithmetic on a null pointer has undefined behavior [-Werror,-Wnull-pointer-arithmetic]
__raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:604:59: error: performing pointer arithmetic on a null pointer has undefined behavior [-Werror,-Wnull-pointer-arithmetic]
__raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
~~~~~~~~~~ ^
include/asm-generic/io.h:692:20: error: performing pointer arithmetic on a null pointer has undefined behavior [-Werror,-Wnull-pointer-arithmetic]
readsb(PCI_IOBASE + addr, buffer, count);
~~~~~~~~~~ ^
include/asm-generic/io.h:700:20: error: performing pointer arithmetic on a null pointer has undefined behavior [-Werror,-Wnull-pointer-arithmetic]
readsw(PCI_IOBASE + addr, buffer, count);
~~~~~~~~~~ ^
include/asm-generic/io.h:708:20: error: performing pointer arithmetic on a null pointer has undefined behavior [-Werror,-Wnull-pointer-arithmetic]
readsl(PCI_IOBASE + addr, buffer, count);
~~~~~~~~~~ ^
include/asm-generic/io.h:717:21: error: performing pointer arithmetic on a null pointer has undefined behavior [-Werror,-Wnull-pointer-arithmetic]
writesb(PCI_IOBASE + addr, buffer, count);
~~~~~~~~~~ ^
include/asm-generic/io.h:726:21: error: performing pointer arithmetic on a null pointer has undefined behavior [-Werror,-Wnull-pointer-arithmetic]
writesw(PCI_IOBASE + addr, buffer, count);
~~~~~~~~~~ ^
include/asm-generic/io.h:735:21: error: performing pointer arithmetic on a null pointer has undefined behavior [-Werror,-Wnull-pointer-arithmetic]
writesl(PCI_IOBASE + addr, buffer, count);
~~~~~~~~~~ ^
>> drivers/net/wwan/t7xx/t7xx_port_devlink.c:465:35: error: use of undeclared identifier 'DEVLINK_SUPPORT_FLASH_UPDATE_COMPONENT'; did you mean 'DEVLINK_ATTR_FLASH_UPDATE_COMPONENT'?
.supported_flash_update_params = DEVLINK_SUPPORT_FLASH_UPDATE_COMPONENT,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
DEVLINK_ATTR_FLASH_UPDATE_COMPONENT
include/uapi/linux/devlink.h:532:2: note: 'DEVLINK_ATTR_FLASH_UPDATE_COMPONENT' declared here
DEVLINK_ATTR_FLASH_UPDATE_COMPONENT, /* string */
^
13 errors generated.
vim +465 drivers/net/wwan/t7xx/t7xx_port_devlink.c
87dae9e70bf7be M Chetan Kumar 2022-08-16 462
87dae9e70bf7be M Chetan Kumar 2022-08-16 463 /* Call back function for devlink ops */
87dae9e70bf7be M Chetan Kumar 2022-08-16 464 static const struct devlink_ops devlink_flash_ops = {
87dae9e70bf7be M Chetan Kumar 2022-08-16 @465 .supported_flash_update_params = DEVLINK_SUPPORT_FLASH_UPDATE_COMPONENT,
87dae9e70bf7be M Chetan Kumar 2022-08-16 466 .flash_update = t7xx_devlink_flash_update,
87dae9e70bf7be M Chetan Kumar 2022-08-16 467 .reload_actions = BIT(DEVLINK_RELOAD_ACTION_DRIVER_REINIT) |
87dae9e70bf7be M Chetan Kumar 2022-08-16 468 BIT(DEVLINK_RELOAD_ACTION_FW_ACTIVATE),
87dae9e70bf7be M Chetan Kumar 2022-08-16 469 .reload_down = t7xx_devlink_reload_down,
87dae9e70bf7be M Chetan Kumar 2022-08-16 470 .reload_up = t7xx_devlink_reload_up,
87dae9e70bf7be M Chetan Kumar 2022-08-16 471 };
87dae9e70bf7be M Chetan Kumar 2022-08-16 472
:::::: The code at line 465 was first introduced by commit
:::::: 87dae9e70bf7be2bd8a3c561fe3ddf666eb8a7a4 net: wwan: t7xx: Enable devlink based fw flashing and coredump collection
:::::: TO: M Chetan Kumar <m.chetan.kumar@...ux.intel.com>
:::::: CC: David S. Miller <davem@...emloft.net>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists