[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220819184311.4ty3hkzfdrrdg4sd@notapiano>
Date: Fri, 19 Aug 2022 14:43:11 -0400
From: NĂcolas F. R. A. Prado
<nfraprado@...labora.com>
To: xinlei.lee@...iatek.com
Cc: chunkuang.hu@...nel.org, p.zabel@...gutronix.de, airlied@...ux.ie,
daniel@...ll.ch, matthias.bgg@...il.com,
dri-devel@...ts.freedesktop.org,
linux-mediatek@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
Project_Global_Chrome_Upstream_Group@...iatek.com,
Jitao Shi <jitao.shi@...iatek.com>
Subject: Re: [PATCH v2,2/2] drm: mediatek: Adjust the dpi output format to
MT8186
Hi Xinlei,
On Fri, Aug 05, 2022 at 05:57:41PM +0800, xinlei.lee@...iatek.com wrote:
> From: Xinlei Lee <xinlei.lee@...iatek.com>
>
> Dpi output needs to adjust the output format to dual edge for MT8186.
Could you explain a bit more why this is needed? What does this configuration
do? And why is MMSYS involved in a DPI configuration?
Also, is this a configuration specific to MT8186? I enabled the flag on MT8192
just to test and didn't see any difference in behavior.
>
> Signed-off-by: Jitao Shi <jitao.shi@...iatek.com>
If Jitao also helped in the writing of this code, then there should also be a
co-developed-by tag for Jitao before the Signed-off-by [1].
[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
> Signed-off-by: Xinlei Lee <xinlei.lee@...iatek.com>
[..]
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
[..]
> @@ -151,6 +154,7 @@ struct mtk_dpi_conf {
> u32 yuv422_en_bit;
> u32 csc_enable_bit;
> u32 pixels_per_iter;
> + bool rgb888_dual_enable;
You're missing a description of this property in the struct's comment above:
drivers/gpu/drm/mediatek/mtk_dpi.c:160: warning: Function parameter or member 'rgb888_dual_enable' not described in 'mtk_dpi_conf'
Thanks,
NĂcolas
Powered by blists - more mailing lists