linux-kernel - Re: [PATCH] parisc: move from strlcpy with unused retval to strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <10e7f147-6f7e-76ad-02f9-2db32c533953@gmx.de>
Date:   Fri, 19 Aug 2022 21:26:46 +0200
From:   Helge Deller <deller@....de>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        linux-kernel@...r.kernel.org
Cc:     "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
        linux-parisc@...r.kernel.org
Subject: Re: [PATCH] parisc: move from strlcpy with unused retval to strscpy

On 8/18/22 23:00, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
>
> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

applied to parisc git tree.
Thanks!
Helge

> ---
>  drivers/parisc/led.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/parisc/led.c b/drivers/parisc/led.c
> index 1e4a5663d011..d4be9d2ee74d 100644
> --- a/drivers/parisc/led.c
> +++ b/drivers/parisc/led.c
> @@ -646,7 +646,7 @@ int lcd_print( const char *str )
>  		cancel_delayed_work_sync(&led_task);
>
>  	/* copy display string to buffer for procfs */
> -	strlcpy(lcd_text, str, sizeof(lcd_text));
> +	strscpy(lcd_text, str, sizeof(lcd_text));
>
>  	/* Set LCD Cursor to 1st character */
>  	gsc_writeb(lcd_info.reset_cmd1, LCD_CMD_REG);