[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAHp75Vc=Y8gVuUXmOcj=2nqzNBQyuvjPwNAvfhVvrCnW6oGwVw@mail.gmail.com>
Date: Sat, 20 Aug 2022 01:07:33 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
linux-hwmon@...r.kernel.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Jean Delvare <jdelvare@...e.com>
Subject: Re: [PATCH v1 1/1] hwmon: (iio_hwmon) Make use of device properties
On Fri, Aug 19, 2022 at 4:03 PM Guenter Roeck <linux@...ck-us.net> wrote:
> On Fri, Aug 19, 2022 at 12:50:46PM +0300, Andy Shevchenko wrote:
> > On Fri, Aug 19, 2022 at 2:52 AM Guenter Roeck <linux@...ck-us.net> wrote:
> > > On Sat, Jul 30, 2022 at 03:50:24PM +0300, Andy Shevchenko wrote:
...
> > > > Add mod_devicetable.h include.
> > > >
> > > What does that have to do with this patch ?
> >
> > See below.
> >
> > > > +#include <linux/mod_devicetable.h>
> >
> > > > -#include <linux/of.h>
> >
> > The of.h implicitly included missed headers. The mod_devicetable.h is
> > necessary when we drop of.h. OTOH I haven't checked if
> > mod_devicetable.h is still included indirectly. Either way the correct
> > approach is to include mod_devicetable.h since we use a data type from
> > it (of_device_id IIRC).
> >
> Something like
>
> "Include mod_devicetable.h explicitly to replace the dropped of.h which
> included mod_devicetable.h indirectly"
>
> might be useful.
Sure, I will add it in v2.
Thanks for review!
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists