linux-kernel - Re: [PATCH] regulator: core: Clean up on enable failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YwATSglfJEgG6V73@sirena.org.uk>
Date:   Fri, 19 Aug 2022 23:48:42 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Andrew Halaney <ahalaney@...hat.com>
Cc:     lgirdwood@...il.com, linux-kernel@...r.kernel.org,
        bmasney@...hat.com, dianders@...omium.org
Subject: Re: [PATCH] regulator: core: Clean up on enable failure

On Fri, Aug 19, 2022 at 02:43:36PM -0500, Andrew Halaney wrote:

> -	if (regulator->uA_load && regulator->enable_count == 1)
> -		return drms_uA_update(rdev);
> +	if (regulator->uA_load && regulator->enable_count == 1) {
> +		ret = drms_uA_update(rdev);

I am vaugely surprised and a bit concerned that drms_uA_update() can
fail...

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)