[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2ed7d787-f4ee-55af-5279-b13377ea0ec3@amazon.com>
Date: Fri, 19 Aug 2022 10:13:20 +0300
From: "Farber, Eliav" <farbere@...zon.com>
To: Guenter Roeck <linux@...ck-us.net>
CC: <jdelvare@...e.com>, <robh+dt@...nel.org>, <mark.rutland@....com>,
<linux-hwmon@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <talel@...zon.com>,
<hhhawa@...zon.com>, <jonnyc@...zon.com>, <hanochu@...zon.com>,
<ronenk@...zon.com>, <itamark@...zon.com>, <shellykz@...zon.com>,
<shorer@...zon.com>, <amitlavi@...zon.com>, <almogbs@...zon.com>,
<dwmw@...zon.co.uk>, <rtanwar@...linear.com>,
"Farber, Eliav" <farbere@...zon.com>
Subject: Re: [PATCH v2 09/16] hwmon: (mr75203) add VM pre-scalar property for Moortec
PVT controller
On 8/18/2022 11:11 PM, Guenter Roeck wrote:
> Is that how such properties are implemented ? Seems to me that
> results in a lot of decode complexity.
>
> Why not use an array property like the other properties ?
Each VM has up to 16 inputs and there might be more than one VM.
Assuming an example of 2 VMs, and channels 5 and 6 in first VM have pre-
scalar of 2, while channel 2 in the second VM has pre-scalar of 3 and
channel 11 has pre-scalar of 2, the alternative was to do something like
this:
vm-pre-scalar-0=[01 01 01 01 01 02 02 01 01 01 01 01 01 01 01 01];
vm-pre-scalar-1=[01 01 03 01 01 01 01 01 01 01 01 02 01 01 01 01];
Most of the inputs are 01, which are anyway the default.
I don't see a difference in decoding complexity between the different
approaches but if you prefer this I'll modify my patches.
Powered by blists - more mailing lists