linux-kernel - Re: [PATCH] mm: hugetlb_vmemmap: simplify reset_struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a7116c45-a2a3-4c9d-633b-1ae0acd8b927@huawei.com>
Date:   Fri, 19 Aug 2022 15:43:28 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     Muchun Song <songmuchun@...edance.com>
CC:     <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
        <muchun.song@...ux.dev>, Mike Kravetz <mike.kravetz@...cle.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] mm: hugetlb_vmemmap: simplify reset_struct_pages()

On 2022/8/19 11:55, Muchun Song wrote:
> We can choose to copy three contiguous tail pages' content to the first three pages
> instead of copying one by one to simplify the code and reduce code size from 229 bytes
> to 63 bytes. The BUILD_BUG_ON() aims to avoid out-of-bounds accesses.
> 
> Signed-off-by: Muchun Song <songmuchun@...edance.com>

LGTM. Thanks.

Reviewed-by: Miaohe Lin <linmiaohe@...wei.com>

Thanks,
Miaohe Lin