linux-kernel - Re: [PATCH] isofs: delete unnecessary checks before brelse()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220819090701.xvldajjh4gqwa6us@quack3>
Date:   Fri, 19 Aug 2022 11:07:01 +0200
From:   Jan Kara <jack@...e.cz>
To:     cgel.zte@...il.com
Cc:     roman.gushchin@...ux.dev, songmuchun@...edance.com, tytso@....edu,
        jack@...e.cz, willy@...radead.org, linux-kernel@...r.kernel.org,
        Minghao Chi <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] isofs: delete unnecessary checks before brelse()

On Fri 19-08-22 08:14:20, cgel.zte@...il.com wrote:
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> The brelse() function tests whether its argument is NULL
> and then returns immediately.
> Thus remove the tests which are not needed around the shown calls.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>

Thanks for the cleanup. I have added the patch to my tree.

								Honza

> ---
>  fs/isofs/inode.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c
> index 88bf20303466..df9d70588b60 100644
> --- a/fs/isofs/inode.c
> +++ b/fs/isofs/inode.c
> @@ -1277,13 +1277,11 @@ static int isofs_read_level3_size(struct inode *inode)
>  	} while (more_entries);
>  out:
>  	kfree(tmpde);
> -	if (bh)
> -		brelse(bh);
> +	brelse(bh);
>  	return 0;
>  
>  out_nomem:
> -	if (bh)
> -		brelse(bh);
> +	brelse(bh);
>  	return -ENOMEM;
>  
>  out_noread:
> @@ -1486,8 +1484,7 @@ static int isofs_read_inode(struct inode *inode, int relocated)
>  	ret = 0;
>  out:
>  	kfree(tmpde);
> -	if (bh)
> -		brelse(bh);
> +	brelse(bh);
>  	return ret;
>  
>  out_badread:
> -- 
> 2.25.1
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR