linux-kernel - Re: [PATCH -next v2] bootmem: remove the vmemmap pages from kmemleak in put_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <9B9B1BE4-3D6F-4D68-8741-8888AA2FEFB1@linux.dev>
Date:   Fri, 19 Aug 2022 17:49:20 +0800
From:   Muchun Song <muchun.song@...ux.dev>
To:     Liu Shixin <liushixin2@...wei.com>
Cc:     Muchun Song <songmuchun@...edance.com>,
        Matthew Wilcox <willy@...radead.org>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Oscar Salvador <osalvador@...e.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, Linux MM <linux-mm@...ck.org>
Subject: Re: [PATCH -next v2] bootmem: remove the vmemmap pages from kmemleak
 in put_page_bootmem



> On Aug 19, 2022, at 17:40, Liu Shixin <liushixin2@...wei.com> wrote:
> 
> The vmemmap pages is marked by kmemleak when allocated from memblock.
> Remove it from kmemleak when free the page. Otherwise, when we reuse the
> page, kmemleak may report such an error and then stop working.
> 
> kmemleak: Cannot insert 0xffff98fb6eab3d40 into the object search tree (overlaps existing)
> kmemleak: Kernel memory leak detector disabled
> kmemleak: Object 0xffff98fb6be00000 (size 335544320):
> kmemleak:   comm "swapper", pid 0, jiffies 4294892296
> kmemleak:   min_count = 0
> kmemleak:   count = 0
> kmemleak:   flags = 0x1
> kmemleak:   checksum = 0
> kmemleak:   backtrace:
> 
> Fixes: f41f2ed43ca5 (mm: hugetlb: free the vmemmap pages associated with each HugeTLB page)
> Signed-off-by: Liu Shixin <liushixin2@...wei.com>

Thanks for fixing this.

Reviewed-by: Muchun Song <songmuchun@...edance.com>