linux-kernel - Re: [PATCH] KVM: s390: pci: Hook to access KVM lowlevel from VFIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 19 Aug 2022 13:49:29 +0200
From:   Niklas Schnelle <schnelle@...ux.ibm.com>
To:     Pierre Morel <pmorel@...ux.ibm.com>, mjrosato@...ux.ibm.com
Cc:     rdunlap@...radead.org, linux-kernel@...r.kernel.org, lkp@...el.com,
        borntraeger@...ux.ibm.com, farman@...ux.ibm.com,
        linux-s390@...r.kernel.org, kvm@...r.kernel.org, gor@...ux.ibm.com,
        hca@...ux.ibm.com, frankja@...ux.ibm.com
Subject: Re: [PATCH] KVM: s390: pci: Hook to access KVM lowlevel from VFIO

---8<---
> > > > > diff --git a/arch/s390/pci/Makefile b/arch/s390/pci/Makefile
> > > > > index bf557a1b789c..c02dbfb415d9 100644
> > > > > --- a/arch/s390/pci/Makefile
> > > > > +++ b/arch/s390/pci/Makefile
> > > > > @@ -7,3 +7,5 @@ obj-$(CONFIG_PCI)	+= pci.o pci_irq.o pci_dma.o pci_clp.o pci_sysfs.o \
> > > > >    			   pci_event.o pci_debug.o pci_insn.o pci_mmio.o \
> > > > >    			   pci_bus.o
> > > > >    obj-$(CONFIG_PCI_IOV)	+= pci_iov.o
> > > > > +
> > > > > +obj-y += pci_kvm_hook.o
> > > > 
> > > > I thought we wanted to compile this only for CONFIG_PCI?
> > > 
> > > Ah sorry, that is indeed what I understood with Matt but then I
> > > misunderstood your own answer from yesterday.
> > > I change to
> > > obj-$(CONFIG_PCI) += pci_kvm_hook.o
> > > 
> > > > > diff --git a/arch/s390/pci/pci_kvm_hook.c b/arch/s390/pci/pci_kvm_hook.c
> > > > > new file mode 100644
> > > > > index 000000000000..ff34baf50a3e
> > > > ---8<---
> > > > 
> > 
> > Ok with the two things above plus the comment by Matt incorporated:
> > 
> > Reviewed-by: Niklas Schnelle <schnelle@...ux.ibm.com>
> > 
> 
> Just a little correction, it changes nothing if the pci_kvm_hook.c goes 
> on same lines as other CONFIG_PCI depending files.
> So I put it on the same line.
> 
> Thanks
> 
> Pierre
> 

Of course yes. Thanks for fixing this and I'm assuming this would
either go through the KVM or vfio trees, correct?