linux-kernel - Re: [PATCH 5.15 218/779] regulator: of: Fix refcount leak bug in of_get_regulation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220819131023.GB11901@duo.ucw.cz>
Date:   Fri, 19 Aug 2022 15:10:23 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Liang He <windhl@....com>, Mark Brown <broonie@...nel.org>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 5.15 218/779] regulator: of: Fix refcount leak bug in
 of_get_regulation_constraints()

Hi!

> From: Liang He <windhl@....com>
> 
> [ Upstream commit 66efb665cd5ad69b27dca8571bf89fc6b9c628a4 ]
> 
> We should call the of_node_put() for the reference returned by
> of_get_child_by_name() which has increased the refcount.

Looks okay,

> +++ b/drivers/regulator/of_regulator.c
> @@ -264,8 +264,12 @@ static int of_get_regulation_constraints(struct device *dev,
>  		}
>  
>  		suspend_np = of_get_child_by_name(np, regulator_states[i]);
> -		if (!suspend_np || !suspend_state)
> +		if (!suspend_np)
>  			continue;
> +		if (!suspend_state) {
> +			of_node_put(suspend_np);
> +			continue;
> +		}
>  

but note that of_node_put(NULL) should be okay, so this can be cleaned
up.

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)