[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Yv+qSDUEs+6T8b9+@kroah.com>
Date: Fri, 19 Aug 2022 17:20:40 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc: kishon@...com, lpieralisi@...nel.org, linux-pci@...r.kernel.org,
linux-kernel@...r.kernel.org, mie@...l.co.jp, kw@...ux.com
Subject: Re: [PATCH 2/5] misc: pci_endpoint_test: Fix the return value of
IOCTL
On Fri, Aug 19, 2022 at 08:20:15PM +0530, Manivannan Sadhasivam wrote:
> IOCTLs are supposed to return 0 for success and negative error codes for
> failure. Currently, this driver is returning 0 for failure and 1 for
> success, that's not correct. Hence, fix it!
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
This needs to come first in the series, along with a Fixes: tag, and a
cc: stable tag so that it can be properly backported and fixed up
everywhere.
thanks,
greg k-h
Powered by blists - more mailing lists