linux-kernel - Re: [PATCH RESEND 1/2] i2c: tegra: Add GPCDMA support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89a746fd-a98e-3147-7811-33c5051c2b6d@gmail.com>
Date:   Fri, 19 Aug 2022 18:27:10 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Akhil R <akhilrajeev@...dia.com>, robh+dt@...nel.org,
        devicetree@...r.kernel.org, christian.koenig@....com,
        jonathanh@...dia.com, ldewangan@...dia.com,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, sumit.semwal@...aro.org,
        thierry.reding@...il.com, wsa@...nel.org
Subject: Re: [PATCH RESEND 1/2] i2c: tegra: Add GPCDMA support

19.08.2022 18:15, Dmitry Osipenko пишет:
> 19.08.2022 15:23, Akhil R пишет:
>>  	if (of_device_is_compatible(np, "nvidia,tegra210-i2c-vi"))
>>  		i2c_dev->is_vi = true;
>> +	else
>> +		i2c_dev->dma_support = !!(of_find_property(np, "dmas", NULL));
> 
> 1. You leak the np returned by of_find_property().
> 
> 2. There is device_property_read_bool() for this kind of property-exists
> checks.
> 
> 3. If "dmas" is missing in DT, then dma_request_chan() should return
> NULL and everything will work fine. I suppose you haven't tried to test
> this code.

Although, no. It should return ERR_PTR(-ENODEV) and then you should
check the return code.