lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 20 Aug 2022 17:59:33 +0800 From: Jeffy Chen <jeffy.chen@...k-chips.com> To: Heiko Stuebner <heiko@...ech.de>, Doug Anderson <dianders@...omium.org> Cc: Jeffy Chen <jeffy.chen@...k-chips.com>, linux-rockchip@...ts.infradead.org, Bartosz Golaszewski <brgl@...ev.pl>, Linus Walleij <linus.walleij@...aro.org>, linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Subject: [PATCH 2/2] gpio/rockchip: Toggle edge trigger mode after acking Otherwise the trigger mode might be out-of-sync when a level change occurred in between. Fixes: 53b1bfc76df2 ("pinctrl: rockchip: Avoid losing interrupts when supporting both edges") Signed-off-by: Jeffy Chen <jeffy.chen@...k-chips.com> --- drivers/gpio/gpio-rockchip.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c index a98351cd6821..736b4d90f1ca 100644 --- a/drivers/gpio/gpio-rockchip.c +++ b/drivers/gpio/gpio-rockchip.c @@ -338,7 +338,7 @@ static void rockchip_irq_demux(struct irq_desc *desc) irq = __ffs(pend); pend &= ~BIT(irq); - dev_dbg(bank->dev, "handling irq %d\n", irq); + generic_handle_domain_irq(bank->domain, irq); /* * Triggering IRQ on both rising and falling edge @@ -370,8 +370,6 @@ static void rockchip_irq_demux(struct irq_desc *desc) bank->gpio_regs->ext_port); } while ((data & BIT(irq)) != (data_old & BIT(irq))); } - - generic_handle_domain_irq(bank->domain, irq); } chained_irq_exit(chip, desc); -- 2.20.1
Powered by blists - more mailing lists