linux-kernel - Re: [PATCH] iio: light: cm32181: make cm32181_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220820125709.7df567c1@jic23-huawei>
Date:   Sat, 20 Aug 2022 12:57:09 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     sunliming <sunliming@...inos.cn>
Cc:     ktsai@...ellamicro.com, lars@...afoo.de,
        kai.heng.feng@...onical.com, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, kelulanainsley@...il.com,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] iio: light: cm32181: make cm32181_pm_ops static

On Mon, 15 Aug 2022 09:29:30 +0800
sunliming <sunliming@...inos.cn> wrote:

> This symbol is not used outside of cm32181.c, so marks it static.
> 
> Fixes the following sparse warnings:
> >> drivers/iio/light/cm32181.c:508:1: sparse: sparse: symbol 'cm32181_pm_ops'  
> was not declared. Should it be static?
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: sunliming <sunliming@...inos.cn>

Applied.  Thanks,
> ---
>  drivers/iio/light/cm32181.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/light/cm32181.c b/drivers/iio/light/cm32181.c
> index edbe6a3138d0..001055d09750 100644
> --- a/drivers/iio/light/cm32181.c
> +++ b/drivers/iio/light/cm32181.c
> @@ -505,7 +505,7 @@ static int cm32181_resume(struct device *dev)
>  					 cm32181->conf_regs[CM32181_REG_ADDR_CMD]);
>  }
>  
> -DEFINE_SIMPLE_DEV_PM_OPS(cm32181_pm_ops, cm32181_suspend, cm32181_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(cm32181_pm_ops, cm32181_suspend, cm32181_resume);
>  
>  static const struct of_device_id cm32181_of_match[] = {
>  	{ .compatible = "capella,cm3218" },