linux-kernel - Re: [PATCH v1] selinux/ss/services.c: check the return value of audit_log_start() in security_sid_mls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 20 Aug 2022 10:19:47 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     lily <floridsleeves@...il.com>
Cc:     selinux@...r.kernel.org, linux-kernel@...r.kernel.org,
        stephen.smalley.work@...il.com, eparis@...isplace.org,
        cgzones@...glemail.com, michalorzel.eng@...il.com,
        xiujianfeng@...wei.com, omosnace@...hat.com
Subject: Re: [PATCH v1] selinux/ss/services.c: check the return value of
 audit_log_start() in security_sid_mls_copy()

On Sat, Aug 20, 2022 at 4:26 AM lily <floridsleeves@...il.com> wrote:
>
> The function audit_log_start() can fail, so its return value should be
> checked against NULL.
>
> Signed-off-by: Li Zhong <floridsleeves@...il.com>
> ---
>  security/selinux/ss/services.c | 3 +++
>  1 file changed, 3 insertions(+)

audit_log_start() can safely return NULL as the audit_log_*()
functions are designed to handle a NULL audit_buffer.  This is an
expected behavior and not a bug.

-- 
paul-moore.com