linux-kernel - Re: [PATCH v2 0/4] remove useless files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+sZ8B8ouMSMmArTVzbkqeWQx4Zqg2=gPaviTrkOFvBoswv_Jg@mail.gmail.com>
Date:   Sat, 20 Aug 2022 16:35:50 +0200
From:   Nam Cao <namcaov@...il.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     lkp@...el.com, Larry.Finger@...inger.net,
        gregkh@...uxfoundation.org, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH v2 0/4] remove useless files

Hi

On Sat, Aug 20, 2022 at 2:17 PM Hans de Goede <hdegoede@...hat.com> wrote:
>
> Hi,
>
> Patch 1/4 seems to be missing?

Patch 1/4 is there:
https://lore.kernel.org/linux-staging/46d73e331bae2192a328f6691763f39ea6c18b08.1660977536.git.namcaov@gmail.com/

>
> Also please squash patches 3 and 4:
>
>    staging: rtl8723bs: remove odm_NoiseMonitor.o from Makefile
>    staging: rtl8723bs: remove odm_NoiseMonitor.h and odm_NoiseMonitor.c
>
> together. Ion other words remove both the files and the Makefile
> target in a single patch please.

Sorry but I am not sure what I am supposed to do with kernel test bot.
I agree that it makes sense to squash these 2 commits together. However,
I separated them because I want to have 1 patch addressing the problem reported
by the bot, so that I can put the "Reported-by" line to this patch.

If I squash them, should I still put in the "Reported-by" line, despite the
commit not exactly fixing the reported error. Or should I just leave it out?

>
> Regards,
>
> Hans
>

Thanks for spending time reviewing.

Best regards,

Nam