linux-kernel - Re: [PATCH 5.15 089/779] md-raid10: fix KASAN warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.02.2208201202090.15558@file01.intranet.prod.int.rdu2.redhat.com>
Date:   Sat, 20 Aug 2022 12:03:48 -0400 (EDT)
From:   Mikulas Patocka <mpatocka@...hat.com>
To:     Pavel Machek <pavel@...x.de>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Song Liu <song@...nel.org>, Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH 5.15 089/779] md-raid10: fix KASAN warning



On Fri, 19 Aug 2022, Pavel Machek wrote:

> Hi!
> 
> > From: Mikulas Patocka <mpatocka@...hat.com>
> > 
> > commit d17f744e883b2f8d13cca252d71cfe8ace346f7d upstream.
> > 
> > There's a KASAN warning in raid10_remove_disk when running the lvm
> > test lvconvert-raid-reshape.sh. We fix this warning by verifying that the
> > value "number" is valid.
> > 
> > BUG: KASAN: slab-out-of-bounds in raid10_remove_disk+0x61/0x2a0 [raid10]
> > Read of size 8 at addr ffff889108f3d300 by task mdX_raid10/124682
> 
> Is this place for array_index_nospec?
> 
> Best regards,
> 								Pavel

Hi

I think it is not needed - userspace code can't trigger this code path at 
will.

Mikulas