linux-kernel - Re: [PATCH] LoongArch: Select PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b2e77db8-0037-e890-cdda-8bbce1786fa9@infradead.org>
Date:   Sat, 20 Aug 2022 11:05:35 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Huacai Chen <chenhuacai@...ngson.cn>,
        Arnd Bergmann <arnd@...db.de>,
        Huacai Chen <chenhuacai@...nel.org>
Cc:     loongarch@...ts.linux.dev, linux-arch@...r.kernel.org,
        Xuefeng Li <lixuefeng@...ngson.cn>,
        Guo Ren <guoren@...nel.org>, Xuerui Wang <kernel@...0n.name>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] LoongArch: Select PCI_QUIRKS to avoid build error



On 8/19/22 19:57, Huacai Chen wrote:
> PCI_LOONGSON is a mandatory for LoongArch and it is selected in Kconfig
> unconditionally, but its dependency PCI_QUIRKS is missing and may cause
> a build error when "make randconfig":
> 
>    arch/loongarch/pci/acpi.c: In function 'pci_acpi_setup_ecam_mapping':
>>> arch/loongarch/pci/acpi.c:103:29: error: 'loongson_pci_ecam_ops' undeclared (first use in this function)
>      103 |                 ecam_ops = &loongson_pci_ecam_ops;
>          |                             ^~~~~~~~~~~~~~~~~~~~~
>    arch/loongarch/pci/acpi.c:103:29: note: each undeclared identifier is reported only once for each function it appears in
> 
> Kconfig warnings: (for reference only)
>    WARNING: unmet direct dependencies detected for PCI_LOONGSON
>    Depends on [n]: PCI [=y] && (MACH_LOONGSON64 [=y] || COMPILE_TEST [=y]) && (OF [=y] || ACPI [=y]) && PCI_QUIRKS [=n]
>    Selected by [y]:
>    - LOONGARCH [=y]
> 
> Fix it by selecting PCI_QUIRKS unconditionally, too.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Huacai Chen <chenhuacai@...ngson.cn>

Tested-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

Thanks.

> ---
>  arch/loongarch/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig
> index 4abc9a28aba4..26aeb1408e56 100644
> --- a/arch/loongarch/Kconfig
> +++ b/arch/loongarch/Kconfig
> @@ -111,6 +111,7 @@ config LOONGARCH
>  	select PCI_ECAM if ACPI
>  	select PCI_LOONGSON
>  	select PCI_MSI_ARCH_FALLBACKS
> +	select PCI_QUIRKS
>  	select PERF_USE_VMALLOC
>  	select RTC_LIB
>  	select SMP

-- 
~Randy