[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <cc31738f-53d7-df04-03fb-f6a32a9493fb@gmail.com>
Date: Fri, 19 Aug 2022 19:57:43 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Xiaolei Wang <xiaolei.wang@...driver.com>, andrew@...n.ch,
hkallweit1@...il.com
Cc: linux@...linux.org.uk, davem@...emloft.net, edumazet@...gle.com,
kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [v2][PATCH] net: phy: Don't WARN for PHY_READY state in
mdio_bus_phy_resume()
On 8/19/2022 1:24 AM, Xiaolei Wang wrote:
> For some MAC drivers, they set the mac_managed_pm to true in its
> ->ndo_open() callback. So before the mac_managed_pm is set to true,
> we still want to leverage the mdio_bus_phy_suspend()/resume() for
> the phy device suspend and resume. In this case, the phy device is
> in PHY_READY, and we shouldn't warn about this. It also seems that
> the check of mac_managed_pm in WARN_ON is redundant since we already
> check this in the entry of mdio_bus_phy_resume(), so drop it.
>
> Fixes: 744d23c71af3 ("net: phy: Warn about incorrect mdio_bus_phy_resume() state")
> Signed-off-by: Xiaolei Wang <xiaolei.wang@...driver.com>
Acked-by: Florian Fainelli <f.fainelli@...il.com>
I see the use case you have and it does make sense to me, thanks!
--
Florian
Powered by blists - more mailing lists