linux-kernel - Re: [PATCH] IB: move from strlcpy with unused retval to strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 21 Aug 2022 14:18:11 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc:     linux-kernel@...r.kernel.org, Jason Gunthorpe <jgg@...pe.ca>,
        Selvin Xavier <selvin.xavier@...adcom.com>,
        Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>,
        Bart Van Assche <bvanassche@....org>,
        linux-rdma@...r.kernel.org, target-devel@...r.kernel.org
Subject: Re: [PATCH] IB: move from strlcpy with unused retval to strscpy

On Thu, Aug 18, 2022 at 11:00:18PM +0200, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
> 
> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> ---
>  drivers/infiniband/core/cma_configfs.c             | 2 +-
>  drivers/infiniband/core/device.c                   | 4 ++--
>  drivers/infiniband/hw/bnxt_re/main.c               | 2 +-
>  drivers/infiniband/hw/hfi1/file_ops.c              | 2 +-
>  drivers/infiniband/hw/hfi1/verbs.c                 | 2 +-
>  drivers/infiniband/hw/mthca/mthca_cmd.c            | 2 +-
>  drivers/infiniband/hw/ocrdma/ocrdma_hw.c           | 2 +-
>  drivers/infiniband/hw/qib/qib_iba7322.c            | 2 +-
>  drivers/infiniband/ulp/ipoib/ipoib_ethtool.c       | 4 ++--
>  drivers/infiniband/ulp/opa_vnic/opa_vnic_ethtool.c | 4 ++--
>  drivers/infiniband/ulp/srpt/ib_srpt.c              | 2 +-
>  11 files changed, 14 insertions(+), 14 deletions(-)

You forgot to change strlcpy in include/rdma/rdma_vt.h file.

I changed locally and applied to -next.

Thanks