linux-kernel - Re: [PATCH v2 6/6] tracing: Have filter accept "common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220822001430.7f885eb32efc53c1388dd132@kernel.org>
Date:   Mon, 22 Aug 2022 00:14:30 +0900
From:   Masami Hiramatsu (Google) <mhiramat@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Tzvetomir Stoyanov <tz.stoyanov@...il.com>,
        Tom Zanussi <zanussi@...nel.org>, stable@...r.kernel.org
Subject: Re: [PATCH v2 6/6] tracing: Have filter accept "common_cpu" to be
 consistent

On Sat, 20 Aug 2022 09:43:22 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> From: "Steven Rostedt (Google)" <rostedt@...dmis.org>
> 
> Make filtering consistent with histograms. As "cpu" can be a field of an
> event, allow for "common_cpu" to keep it from being confused with the
> "cpu" field of the event.
> 
> Link: https://lore.kernel.org/all/20220820220920.e42fa32b70505b1904f0a0ad@kernel.org/
> 

This looks good to me. Thanks!

Acked-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>

> Cc: stable@...r.kernel.org
> Fixes: 1e3bac71c5053 ("tracing/histogram: Rename "cpu" to "common_cpu"")
> Suggested-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> ---
>  kernel/trace/trace_events.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> index 181f08186d32..0356cae0cf74 100644
> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -176,6 +176,7 @@ static int trace_define_generic_fields(void)
>  
>  	__generic_field(int, CPU, FILTER_CPU);
>  	__generic_field(int, cpu, FILTER_CPU);
> +	__generic_field(int, common_cpu, FILTER_CPU);
>  	__generic_field(char *, COMM, FILTER_COMM);
>  	__generic_field(char *, comm, FILTER_COMM);
>  
> -- 
> 2.35.1


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>