linux-kernel - Re: [PATCH] usb/serial: fix repeated words in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6f3059bf-1a12-8ad4-305c-50fc5e0782bc@microchip.com>
Date:   Sun, 21 Aug 2022 15:42:55 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <yuanjilin@...rlc.com>, <johan@...nel.org>,
        <gregkh@...uxfoundation.org>
CC:     <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb/serial: fix repeated words in comments

Hi,
On 21/08/2022 16:34, Jilin Yuan wrote:
>  Delete the redundant word 'more'.
> 
> Signed-off-by: Jilin Yuan <yuanjilin@...rlc.com>
> ---
>  drivers/usb/serial/mct_u232.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/serial/mct_u232.h b/drivers/usb/serial/mct_u232.h
> index e3d09a83cab1..f79a1f1b6a98 100644
> --- a/drivers/usb/serial/mct_u232.h
> +++ b/drivers/usb/serial/mct_u232.h
> @@ -273,13 +273,13 @@ static int mct_u232_calculate_baud_rate(struct usb_serial *serial,
>   *  Bit 5: Data Set Ready (DSR). Reflects the state of the DSR line on the UART.
>   *  Bit 4: Clear To Send (CTS). Reflects the state of the CTS line on the UART.
>   *  Bit 3: Delta Data Carrier Detect (DDCD). Set to "1" if the -DCD line has
> - *	   changed state one more more times since the last time the MSR was
> + *	   changed state one more times since the last time the MSR was

This does not really make much sense before or after the patch.
Should it read: "one or more times"?

Thanks,
Conor.

>   *	   read by the host.
>   *  Bit 2: Trailing Edge Ring Indicator (TERI). Set to "1" if the -RI line has
>   *	   had a low to high transition since the last time the MSR was read by
>   *	   the host.
>   *  Bit 1: Delta Data Set Ready (DDSR). Set to "1" if the -DSR line has changed
> - *	   state one more more times since the last time the MSR was read by the
> + *	   state one more times since the last time the MSR was read by the
>   *	   host.
>   *  Bit 0: Delta Clear To Send (DCTS). Set to "1" if the -CTS line has changed
>   *	   state one more times since the last time the MSR was read by the