linux-kernel - Re: [PATCH] drivers: char: mem: changed 'unsigned' to 'unsigned int'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BA62DE39-AFED-47BC-964C-8AF150A0B9F1@thepaulodoom.com>
Date:   Sun, 21 Aug 2022 15:49:28 +0000
From:   ThePaulODoom <thepaulodoom@...paulodoom.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     arnd@...db.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: char: mem: changed 'unsigned' to 'unsigned int'



On August 21, 2022 8:35:23 AM UTC, Greg KH <gregkh@...uxfoundation.org> wrote:
>On Thu, Aug 18, 2022 at 08:52:37PM -0500, Paul Lemmermann wrote:
>> On Thu, Aug 18, 2022 at 04:52:11PM +0200, Greg KH wrote:
>> > On Tue, Aug 16, 2022 at 08:35:31PM -0500, Paul Lemmermann wrote:
>> > > found with checkpatch.pl
>> > 
>> > That is a very sparse changelog text.
>> > 
>> > Why make this change?  Please be descriptive.
>> > 
>> I wanted to make this change to be more fitting with the kernel coding
>> guidelines, and to reduce a WARNING made with checkpatch preferring the
>> use of 'unsigned int' over 'unsigned'. With NOMMU_MAP_COPY defined in
>> 'include/linux/fs.h' as an unsigned integer, I felt like the change was
>> fitting. I was quickly reminded that the changelog was not properly done, 
>> and I now understand that, and will learn from my mistake in the future.
>> As I am a new kernel contributor, and looking to hone my skills, what are 
>> my next steps? 
>> 
>> Should I:
>> 
>> o Drop the patch and resubmit it,
>> o Simply drop the patch,
>> o Could I change it somehow?,
>> o Or something else?
>
>Try something else.  Start out by working in drivers/staging/ on basic
>coding style fixes and other things listed in the drivers/staging/*/TODO
>files.  That's the best place for new developers to get started and then

That's what I'll do. Again, thank you for being patient and guiding me in the right direction! 

Many thanks,
- Paul