linux-kernel - Re: [PATCH v1] net/ipv6/addrconf.c: Check the return value of __in6_dev_get() in addrconf_type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YwJ3HufZK/784UQc@pop-os.localdomain>
Date:   Sun, 21 Aug 2022 11:19:10 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     lily <floridsleeves@...il.com>
Cc:     ziw002@....ucsd.edu, lizhong@...d.edu, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, davem@...emloft.net,
        yoshfuji@...ux-ipv6.org, dsahern@...nel.org, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com
Subject: Re: [PATCH v1] net/ipv6/addrconf.c: Check the return value of
 __in6_dev_get() in addrconf_type_change()

On Sat, Aug 20, 2022 at 03:24:34AM -0700, lily wrote:
> The function __in6_dev_get() could return NULL pointer. This needs to be
> checked before used in ipv6_mc_remap() and ipv6_mc_unmap(). Otherwise it
> could result in null pointer dereference.

Its caller already checks it:

3689                 if (idev)
3690                         addrconf_type_change(dev, event);
3691                 break;