linux-kernel - Re: [PATCH] [RFC] arm64: dts: qcom: sdm845-xiaomi-polaris: Fix sde_dsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 21 Aug 2022 19:25:16 +0000
From:   Caleb Connolly <caleb@...nolly.tech>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Molly Sophia <mollysophia379@...il.com>
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [RFC] arm64: dts: qcom: sdm845-xiaomi-polaris: Fix sde_dsi_active pinctrl



On 19/08/2022 11:14, Geert Uytterhoeven wrote:
> "make dtbs_check" says:
>
>      bias-disable: boolean property with value b'\x00\x00\x00\x00'
>
> Fix this by dropping the offending value.
>
> Fixes: be497abe19bf08fb ("arm64: dts: qcom: Add support for Xiaomi Mi Mix2s")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Reviewed-by: Caleb Connolly <caleb@...nolly.tech>
> ---
> Marked RFC as I do not have the hardware or documentation.
> Perhaps the "bias-disable" property should be dropped instead?

This is correct, the ` = <0>` is a downstream style, but it does actually mean to disable the bias
afaik, from downstream docs:

- bias-disable:
	Usage: optional
	Value type: <none>
	Definition: The specified pins should be configued as no pull.


> ---
>   arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
> index 7747081b98875aad..dba7c2693ff50073 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts
> @@ -617,7 +617,7 @@ sde_dsi_active: sde-dsi-active {
>   		pins = "gpio6", "gpio10";
>   		function = "gpio";
>   		drive-strength = <8>;
> -		bias-disable = <0>;
> +		bias-disable;
>   	};
>
>   	sde_dsi_suspend: sde-dsi-suspend {
> --
> 2.25.1
>

--
Kind Regards,
Caleb