linux-kernel - Re: [ammarfaizi2-block:viro/vfs/work.termios2 4/8] arch/alpha/kernel/termios.c:5:5: warning: no previous prototype for 'user_termio_to_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YwG+aJKsnkurbSC6@ZenIV>
Date:   Sun, 21 Aug 2022 06:11:04 +0100
From:   Al Viro <viro@...iv.linux.org.uk>
To:     kernel test robot <lkp@...el.com>
Cc:     kbuild-all@...ts.01.org, Ammar Faizi <ammarfaizi2@...weeb.org>,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [ammarfaizi2-block:viro/vfs/work.termios2 4/8]
 arch/alpha/kernel/termios.c:5:5: warning: no previous prototype for
 'user_termio_to_kernel_termios'

On Sun, Aug 21, 2022 at 12:07:05PM +0800, kernel test robot wrote:
> tree:   https://github.com/ammarfaizi2/linux-block viro/vfs/work.termios2
> head:   efc5ae91c846283431afc7bfc57e947bf1fd4158
> commit: 7f3d795b7f3bd329e9b0eea427bcbbf205ee60d5 [4/8] termios: start unifying non-UAPI parts of asm/termios.h
> config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20220821/202208211203.xvc2wVjR-lkp@intel.com/config)
> compiler: alpha-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/ammarfaizi2/linux-block/commit/7f3d795b7f3bd329e9b0eea427bcbbf205ee60d5
>         git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
>         git fetch --no-tags ammarfaizi2-block viro/vfs/work.termios2
>         git checkout 7f3d795b7f3bd329e9b0eea427bcbbf205ee60d5
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash arch/alpha/kernel/

Fixed and folded; incremental is

diff --git b/arch/alpha/kernel/termios.c a/arch/alpha/kernel/termios.c
index 1534f39cb9fe..a4c29a22edf7 100644
--- b/arch/alpha/kernel/termios.c
+++ a/arch/alpha/kernel/termios.c
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0
-#include <linux/uaccess.h>
-#include <linux/termios.h>
+#include <linux/termios_internal.h>
 
 int user_termio_to_kernel_termios(struct ktermios *termios,
 						struct termio __user *termio)
diff --git b/arch/sparc/kernel/termios.c a/arch/sparc/kernel/termios.c
index 97e23d4ae2e2..ee64965c27cd 100644
--- b/arch/sparc/kernel/termios.c
+++ a/arch/sparc/kernel/termios.c
@@ -1,5 +1,5 @@
-#include <linux/uaccess.h>
-#include <linux/termios.h>
+// SPDX-License-Identifier: GPL-2.0
+#include <linux/termios_internal.h>
 
 /*
  * c_cc characters in the termio structure.  Oh, how I love being