linux-kernel - Re: [PATCH 2/6] arm64: dts: imx8mp-venice-gw74xx: remove invalid and unused pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 Aug 2022 10:03:58 -0700
From:   Tim Harvey <tharvey@...eworks.com>
To:     Shawn Guo <shawnguo@...nel.org>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        "Peng Fan (OSS)" <peng.fan@....nxp.com>
Subject: Re: [PATCH 2/6] arm64: dts: imx8mp-venice-gw74xx: remove invalid and
 unused pinctrl_sai2

On Fri, Aug 12, 2022 at 10:35 AM Tim Harvey <tharvey@...eworks.com> wrote:
>
> pinctrl_sai2 is not yet used and not properly defined - remove it to
> avoid:
> imx8mp-pinctrl 30330000.pinctrl: Invalid fsl,pins or pins propert
> y in node /soc@...us@...00000/pinctrl@...30000/sai2grp
>
> Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400 dts
> support")
> Signed-off-by: Tim Harvey <tharvey@...eworks.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> index de17021df53f..80f0f1aafdbf 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> @@ -768,15 +768,6 @@ MX8MP_IOMUXC_NAND_DATA03__GPIO3_IO09       0x110
>                 >;
>         };
>
> -       pinctrl_sai2: sai2grp {
> -               fsl,pins = <
> -                       MX8MP_IOMUXC_SAI2_TXFS__AUDIOMIX_SAI2_TX_SYNC
> -                       MX8MP_IOMUXC_SAI2_TXD0__AUDIOMIX_SAI2_TX_DATA00
> -                       MX8MP_IOMUXC_SAI2_TXC__AUDIOMIX_SAI2_TX_BCLK
> -                       MX8MP_IOMUXC_SAI2_MCLK__AUDIOMIX_SAI2_MCLK
> -               >;
> -       };
> -
>         pinctrl_spi2: spi2grp {
>                 fsl,pins = <
>                         MX8MP_IOMUXC_ECSPI2_SCLK__ECSPI2_SCLK   0x82
> --
> 2.25.1
>

Shawn,

You can drop this. I didn't see Peng's patch commit 706dd9d30d3b
("arm64: dts: imx8mp-venice-gw74xx: fix sai2 pin settings") which
takes care of this.

Best Regards,

Tim