linux-kernel - Re: [PATCH -next] video: fbdev: chipsfb: add missing pci_disable_device() in chipsfb_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b3c19a63-d9f8-028b-e59a-e428be1ed8be@gmx.de>
Date:   Mon, 22 Aug 2022 22:11:58 +0200
From:   Helge Deller <deller@....de>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-fbdev@...r.kernel.org
Cc:     mpe@...erman.id.au, christophe.leroy@...roup.eu,
        benh@...nel.crashing.org
Subject: Re: [PATCH -next] video: fbdev: chipsfb: add missing
 pci_disable_device() in chipsfb_pci_init()

On 8/19/22 10:57, Yang Yingliang wrote:
> Add missing pci_disable_device() in error path in chipsfb_pci_init().
>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>

applied.
Thanks!
Helge

> ---
>  drivers/video/fbdev/chipsfb.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/fbdev/chipsfb.c b/drivers/video/fbdev/chipsfb.c
> index 393894af26f8..2b00a9d554fc 100644
> --- a/drivers/video/fbdev/chipsfb.c
> +++ b/drivers/video/fbdev/chipsfb.c
> @@ -430,6 +430,7 @@ static int chipsfb_pci_init(struct pci_dev *dp, const struct pci_device_id *ent)
>   err_release_fb:
>  	framebuffer_release(p);
>   err_disable:
> +	pci_disable_device(dp);
>   err_out:
>  	return rc;
>  }