linux-kernel - Re: [PATCH v2] platform/chrome: cros_ec: Expose suspend_timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YwMabj1HazWxJEAr@google.com>
Date:   Mon, 22 Aug 2022 05:55:58 +0000
From:   Tzung-Bi Shih <tzungbi@...nel.org>
To:     Prashant Malani <pmalani@...omium.org>
Cc:     Evan Green <evgreen@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Rajat Jain <rajatja@...omium.org>,
        Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        Lee Jones <lee.jones@...aro.org>,
        Tinghan Shen <tinghan.shen@...iatek.com>,
        chrome-platform@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] platform/chrome: cros_ec: Expose suspend_timeout_ms
 in debugfs

On Thu, Aug 18, 2022 at 10:24:23AM -0700, Prashant Malani wrote:
> On Thu, Aug 18, 2022 at 8:29 AM Evan Green <evgreen@...omium.org> wrote:
> > diff --git a/Documentation/ABI/testing/debugfs-cros-ec b/Documentation/ABI/testing/debugfs-cros-ec
> > index 1fe0add99a2a99..9f79c641b2d09f 100644
> > --- a/Documentation/ABI/testing/debugfs-cros-ec
> > +++ b/Documentation/ABI/testing/debugfs-cros-ec
> > @@ -54,3 +54,25 @@ Description:
> >                 this feature.
> >
> >                 Output will be in the format: "0x%08x\n".
> > +
> > +What:          /sys/kernel/debug/<cros-ec-device>/suspend_timeout_ms
> > +Date:          August 2022
> > +KernelVersion: 6.1
> > +Description:
> > +               Some ECs have a feature where they will track transitions to the
> > +               a hardware-controlled sleep line, such as Intel's SLP_S0 line,
> > +               in order to detect cases where a system failed to go into deep
> > +               sleep states. The suspend_timeout file controls the amount of
> s/suspend_timeout/suspend_timeout_ms

Please also fix it in code.