linux-kernel - Re: [PATCH] bonding: Remove unnecessary check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 Aug 2022 13:29:23 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     Sun Shouxin <sunshouxin@...natelecom.cn>
Cc:     Jay Vosburgh <j.vosburgh@...il.com>,
        Veaceslav Falico <vfalico@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        netdev <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        huyd12@...natelecom.cn
Subject: Re: [PATCH] bonding: Remove unnecessary check

On Mon, Aug 22, 2022 at 3:33 AM Sun Shouxin <sunshouxin@...natelecom.cn> wrote:
>
> This check is not necessary since the commit d5410ac7b0ba
> ("net:bonding:support balance-alb interface with vlan to bridge").

Please provide more details. I fail to see the relation between d5410ac7b0ba
and this patch, thanks.

>
> Suggested-by: Hu Yadi <huyd12@...natelecom.cn>
> Signed-off-by: Sun Shouxin <sunshouxin@...natelecom.cn>
> ---
>  drivers/net/bonding/bond_main.c | 13 -------------
>  1 file changed, 13 deletions(-)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 50e60843020c..6b0f0ce9b9a1 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -1578,19 +1578,6 @@ static rx_handler_result_t bond_handle_frame(struct sk_buff **pskb)
>
>         skb->dev = bond->dev;
>
> -       if (BOND_MODE(bond) == BOND_MODE_ALB &&
> -           netif_is_bridge_port(bond->dev) &&
> -           skb->pkt_type == PACKET_HOST) {
> -
> -               if (unlikely(skb_cow_head(skb,
> -                                         skb->data - skb_mac_header(skb)))) {
> -                       kfree_skb(skb);
> -                       return RX_HANDLER_CONSUMED;
> -               }
> -               bond_hw_addr_copy(eth_hdr(skb)->h_dest, bond->dev->dev_addr,
> -                                 bond->dev->addr_len);
> -       }
> -
>         return ret;
>  }
>
> --
> 2.27.0
>