linux-kernel - Re: [PATCH v2 1/8] staging: rtl8723bs: remove function rtw_odm_dbg_comp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220822073352.GA2695@kadam>
Date:   Mon, 22 Aug 2022 10:33:52 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Nam Cao <namcaov@...il.com>
Cc:     lkp@...el.com, Larry.Finger@...inger.net,
        gregkh@...uxfoundation.org, hdegoede@...hat.com,
        kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        linux-staging@...ts.linux.dev
Subject: Re: [PATCH v2 1/8] staging: rtl8723bs: remove function
 rtw_odm_dbg_comp_msg

On Fri, Aug 19, 2022 at 03:49:35PM +0200, Nam Cao wrote:
> because this function is not used.
> 
> Signed-off-by: Nam Cao <namcaov@...il.com>

This patch is fine, but in the future can you please treat the subject
as separate from the commit message.  "because it is not used" is a
sucky commit message.  What is not used?  What are you doing to it?  It
doesn't start with a capital letter.

Here is how your email looks like on lore.

https://lore.kernel.org/all/7ff2d658863db4fd5eecc1a53f682510c2765c3f.1660916523.git.namcaov@gmail.com/

Try to find the subject in the middle of the block of text.  People are
often only going to read the body of the email.

[PATCH v2 1/8] staging: rtl8723bs: remove rtw_odm_dbg_comp_msg()

The rtw_odm_dbg_comp_msg() function is not used.  Delete it.

Signed-off-by:

regards,
dan carpenter