linux-kernel - Re: [PATCH net v2 RESEND] net: neigh: don't call kfree_skb() under spin_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b41b5065-c012-3b3a-2980-3eba25e0a071@blackwall.org>
Date:   Mon, 22 Aug 2022 10:49:55 +0300
From:   Nikolay Aleksandrov <razor@...ckwall.org>
To:     Yang Yingliang <yangyingliang@...wei.com>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Cc:     den@...nvz.org, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org
Subject: Re: [PATCH net v2 RESEND] net: neigh: don't call kfree_skb() under
 spin_lock_irqsave()

On 22/08/2022 05:53, Yang Yingliang wrote:
> It is not allowed to call kfree_skb() from hardware interrupt
> context or with interrupts being disabled. So add all skb to
> a tmp list, then free them after spin_unlock_irqrestore() at
> once.
> 
> Fixes: 66ba215cb513 ("neigh: fix possible DoS due to net iface start/stop loop")
> Suggested-by: Denis V. Lunev <den@...nvz.org>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
> v2:
>   move all skb to a tmp list, then free them after spin_unlock_irqrestore().
> ---
>  net/core/neighbour.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 

LGTM,
Reviewed-by: Nikolay Aleksandrov <razor@...ckwall.org>