linux-kernel - Re: [PATCH] platform/renesas: fix repeated words in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220822083950.xnuwzz5specjpmxq@uno.localdomain>
Date:   Mon, 22 Aug 2022 10:39:50 +0200
From:   Jacopo Mondi <jacopo@...ndi.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     wangjianli <wangjianli@...rlc.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/renesas: fix repeated words in comments

Hi Geert

On Mon, Aug 22, 2022 at 10:06:03AM +0200, Geert Uytterhoeven wrote:
> Hi Wangjianli,
>
> On Sun, Aug 21, 2022 at 4:58 PM wangjianli <wangjianli@...rlc.com> wrote:
> >  Delete the redundant word 'on'.
> >
> > Signed-off-by: wangjianli <wangjianli@...rlc.com>
>
> Thanks for your patch!
>
> > --- a/drivers/media/platform/renesas/renesas-ceu.c
> > +++ b/drivers/media/platform/renesas/renesas-ceu.c
> > @@ -1101,7 +1101,7 @@ static int ceu_open(struct file *file)
> >                 return ret;
> >
> >         mutex_lock(&ceudev->mlock);
> > -       /* Causes soft-reset and sensor power on on first open */
> > +       /* Causes soft-reset and sensor power on first open */
>
> The double "on" is actually correct.  Please ask yourself the question:
> "When should the sensor be powered on?".
> Answer: "On first open".
>

So I overlooked this patch so badly, that I didn't get what I meant when I
first wrote this comment ?

> Personally, I would have written "power-on" instead of "power on"
> (cfr. "soft-reset"), so perhaps it's a good idea to make that change,
> to prevent the next person looking for double words falling for
> this again?
>

Wangjianli please ignore my acked-by and follow instead Geert's
suggestion to change this to power-on, if you want to re-submit the
patch.

Thanks Geert for being awake, as I'm clearly not yet.

> >         ret = pm_runtime_resume_and_get(ceudev->dev);
> >         mutex_unlock(&ceudev->mlock);
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds