linux-kernel - Re: [PATCH linux-next] qnx4: delete the unnecessary checks before brelse()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5293718.Sb9uPGUboI@alarsen.net>
Date:   Mon, 22 Aug 2022 11:30:23 +0200
From:   Anders Larsen <al@...rsen.net>
To:     ye xingchen <ye.xingchen@....com.cn>
Cc:     linux-kernel@...r.kernel.org, cgel.zte@...il.com,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] qnx4: delete the unnecessary checks before brelse()

On Monday, 2022-08-22 11:11 cgel.zte@...il.com wrote:
> From: ye xingchen <ye.xingchen@....com.cn>
> 
> The brelse() function tests whether its argument is NULL
> and then returns immediately.
> Thus remove the tests which are not needed around the shown calls.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
> ---
>  fs/qnx4/inode.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/qnx4/inode.c b/fs/qnx4/inode.c
> index 391ea402920d..9dab8f65ba75 100644
> --- a/fs/qnx4/inode.c
> +++ b/fs/qnx4/inode.c
> @@ -118,8 +118,7 @@ unsigned long qnx4_block_map( struct inode *inode, long iblock )
>  				bh = NULL;
>  			}
>  		}
> -		if ( bh )
> -			brelse( bh );
> +			brelse(bh);

When you remove the if() you must decrease the indentation of the following line!

>  	}
>  
>  	QNX4DEBUG((KERN_INFO "qnx4: mapping block %ld of inode %ld = %ld\n",iblock,inode->i_ino,block));

Other than that,

Acked-by: Anders Larsen <al@...rsen.net>