linux-kernel - Re: [PATCH] crypto: move from strlcpy with unused retval to strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YwNnJJuQdpTo4y7Q@gcabiddu-mobl1.ger.corp.intel.com>
Date:   Mon, 22 Aug 2022 12:23:16 +0100
From:   Giovanni Cabiddu <giovanni.cabiddu@...el.com>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>
CC:     <linux-kernel@...r.kernel.org>,
        Boris Brezillon <bbrezillon@...nel.org>,
        Arnaud Ebalard <arno@...isbad.org>,
        Srujana Challa <schalla@...vell.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        <linux-crypto@...r.kernel.org>, <qat-linux@...el.com>
Subject: Re: [PATCH] crypto: move from strlcpy with unused retval to strscpy

On Thu, Aug 18, 2022 at 11:00:03PM +0200, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
> 
> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> ---
For the QAT portion of this patch:
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@...el.com>

BTW, should the patch be split between qat and marvell/octeontx?

Regards,

-- 
Giovanni