linux-kernel - Re: [PATCH v4 3/4] media: amphion: decoder add support for contiguous planes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220822113001.GB17530@tom-ThinkPad-T14s-Gen-2i>
Date:   Mon, 22 Aug 2022 13:30:01 +0200
From:   Tommaso Merciai <tommaso.merciai@...rulasolutions.com>
To:     Ming Qian <ming.qian@....com>
Cc:     mchehab@...nel.org, hverkuil-cisco@...all.nl, shawnguo@...nel.org,
        robh+dt@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        festevam@...il.com, linux-imx@....com, xiahong.bao@....com,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 3/4] media: amphion: decoder add support for
 contiguous planes

Hi Ming,

On Tue, Aug 09, 2022 at 02:50:40PM +0800, Ming Qian wrote:
> decoder add support for contiguous formats
> V4L2_PIX_FMT_NV12_8L128 and V4L2_PIX_FMT_NV12_10BE_8L128
> 
> Signed-off-by: Ming Qian <ming.qian@....com>
> ---
>  drivers/media/platform/amphion/vdec.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/media/platform/amphion/vdec.c b/drivers/media/platform/amphion/vdec.c
> index 48ab664fa7ef..9c3324717cbc 100644
> --- a/drivers/media/platform/amphion/vdec.c
> +++ b/drivers/media/platform/amphion/vdec.c
> @@ -72,12 +72,28 @@ static const struct vpu_format vdec_formats[] = {
>  		.mem_planes = 2,
>  		.comp_planes = 2,
>  		.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
> +		.sibling = V4L2_PIX_FMT_NV12_8L128,
> +	},
> +	{
> +		.pixfmt = V4L2_PIX_FMT_NV12_8L128,
> +		.mem_planes = 1,
> +		.comp_planes = 2,
> +		.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
> +		.sibling = V4L2_PIX_FMT_NV12M_8L128,
>  	},
>  	{
>  		.pixfmt = V4L2_PIX_FMT_NV12M_10BE_8L128,
>  		.mem_planes = 2,
>  		.comp_planes = 2,
>  		.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
> +		.sibling = V4L2_PIX_FMT_NV12_10BE_8L128,
> +	},
> +	{
> +		.pixfmt = V4L2_PIX_FMT_NV12_10BE_8L128,
> +		.mem_planes = 1,
> +		.comp_planes = 2,
> +		.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
> +		.sibling = V4L2_PIX_FMT_NV12M_10BE_8L128
>  	},
>  	{
>  		.pixfmt = V4L2_PIX_FMT_H264,
> -- 
> 2.37.1
> 

Looks good to me. 

Unfortunately I don't have hw for testing more.
I tried to build and reviewed the code seems ok for me.

Reviewed-by: Tommaso Merciai <tommaso.merciai@...rulasolutions.com>

Tommaso

-- 
Tommaso Merciai
Embedded Linux Engineer
tommaso.merciai@...rulasolutions.com
__________________________________

Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@...rulasolutions.com
www.amarulasolutions.com