linux-kernel - Re: [PATCH] tty/serial: fix repeated words in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YwNzv6GXPTG46D3r@kroah.com>
Date:   Mon, 22 Aug 2022 14:17:03 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jilin Yuan <yuanjilin@...rlc.com>
Cc:     jirislaby@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
        kernel@...gutronix.de, festevam@...il.com, linux-imx@....com,
        krzysztof.kozlowski@...aro.org, alim.akhtar@...sung.com,
        linux-serial@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH] tty/serial: fix repeated words in comments

On Mon, Aug 22, 2022 at 08:09:01PM +0800, Jilin Yuan wrote:
>  Delete the redundant word 'power'.
>  Delete the redundant word 'long'.
> 
> Signed-off-by: Jilin Yuan <yuanjilin@...rlc.com>
> ---
>  drivers/tty/serial/imx.c         | 2 +-
>  drivers/tty/serial/samsung_tty.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> index 30edb35a6a15..c72e0dad3544 100644
> --- a/drivers/tty/serial/imx.c
> +++ b/drivers/tty/serial/imx.c
> @@ -2069,7 +2069,7 @@ imx_uart_console_get_options(struct imx_port *sport, int *baud,
>  		{	/*
>  			 * The next code provides exact computation of
>  			 *   baud_raw = round(((uartclk/16) * (ubir + 1)) / (ubmr + 1))
> -			 * without need of float support or long long division,
> +			 * without need of float support or long division,

The original is correct here.

>  			 * which would be required to prevent 32bit arithmetic overflow
>  			 */
>  			unsigned int mul = ubir + 1;
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> index d5ca904def34..af799b79ba25 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> @@ -1353,7 +1353,7 @@ static int apple_s5l_serial_startup(struct uart_port *port)
>  	return ret;
>  }
>  
> -/* power power management control */
> +/* power management control */

Are you sure this isn't also correct?

greg k-h