linux-kernel - Re: [PATCH] usb/serial: fix repeated words in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <YwN138qeP74YZ9Em@hovoldconsulting.com>
Date:   Mon, 22 Aug 2022 14:26:07 +0200
From:   Johan Hovold <johan@...nel.org>
To:     无名 <yuanjilin@...rlc.com>
Cc:     gregkh <gregkh@...uxfoundation.org>,
        linux-usb <linux-usb@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb/serial: fix repeated words in comments

On Mon, Aug 22, 2022 at 07:47:39PM +0800, 无名 wrote:
> Replace 'mode' with 'or'

This is not a proper commit message as it only says what you do, not
why. Try to spell it out.

> Signed-off-by: Jilin Yuan <yuanjilin@...rlc.com&gt;
> ---

Missing changelog here.

> &nbsp;drivers/usb/serial/mct_u232.h | 4 ++--
> &nbsp;1 file changed, 2 insertions(+), 2 deletions(-)

This patch is corrupt and looks like it was sent as HTML too.

Also look at the git log for this file and use the common Subject
prefix.

It's also customary to CC people that have helped review your patch.

Johan