linux-kernel - Re: [PATCH] media: uvcvideo: Fix InterfaceProtocol for Quanta camera

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YwN/jeElxyXpyyfU@pendragon.ideasonboard.com>
Date:   Mon, 22 Aug 2022 16:07:25 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Ricardo Ribalda <ribalda@...omium.org>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: uvcvideo: Fix InterfaceProtocol for Quanta camera

On Mon, Aug 22, 2022 at 04:02:55PM +0300, Laurent Pinchart wrote:
> Hi Ricardo,
> 
> Thank you for the patch.
> 
> On Mon, Aug 08, 2022 at 03:41:06PM +0200, Ricardo Ribalda wrote:
> > The device is using a different InterfaceProtocol than the one set in
> > the original quirk.

Also, I would mention that the device implements UVC 1.5:

The Quanta 0408:4034 camera implements UVC 1.5, and thus sets
bInterfaceProtocol to UVC_PC_PROTOCOL_15. Commit 95f03d973478 ("media:
uvcvideo: Limit power line control for Quanta cameras") added a quirk
for the device that incorrectly specified the UVC 1.0 protocol,
rendering the quirk inoperative. Fix it.

As this is a v6.0 fix, would you mind submitting a v2 with these changes
? Mauro could then pick it up directly.

> > Fixes: 95f03d973478 ("media: uvcvideo: Limit power line control for Quanta cameras")
> > Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>
> > ---
> > 
> > This was fixed on the last version of the patchset. Unfortunately I did
> > checked that it was the version merged :(.
> 
> Oops :-(
> 
> > It is too late to land it in this version?
> 
> I think it can be considered as a v6.0 fix, yes.
> 
> >  drivers/media/usb/uvc/uvc_driver.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> > index 9c05776f11d1..6556158a8888 100644
> > --- a/drivers/media/usb/uvc/uvc_driver.c
> > +++ b/drivers/media/usb/uvc/uvc_driver.c
> > @@ -2740,7 +2740,7 @@ static const struct usb_device_id uvc_ids[] = {
> >  	  .idProduct		= 0x4034,
> >  	  .bInterfaceClass	= USB_CLASS_VIDEO,
> >  	  .bInterfaceSubClass	= 1,
> > -	  .bInterfaceProtocol	= 0,
> > +	  .bInterfaceProtocol	= 1,
> 
> Should we use UVC_PC_PROTOCOL_15 here ?
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> 
> >  	  .driver_info		= (kernel_ulong_t)&uvc_ctrl_power_line_limited },
> >  	/* LogiLink Wireless Webcam */
> >  	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE

-- 
Regards,

Laurent Pinchart