linux-kernel - Re: [PATCH] powerpc: export cpu_smallcore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_NOedr2TGH0W9wVAPkrJyyJ_+eAkEUORbYvShY4UW90sw@mail.gmail.com>
Date:   Mon, 22 Aug 2022 09:31:30 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Michael Ellerman <mpe@...erman.id.au>,
        "Gautham R . Shenoy" <ego@...ux.vnet.ibm.com>,
        amd-gfx@...ts.freedesktop.org, "Pan, Xinhui" <Xinhui.Pan@....com>,
        Felix Kuehling <Felix.Kuehling@....com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        linux-kernel@...r.kernel.org,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Tejun Heo <tj@...nel.org>, Nicholas Piggin <npiggin@...il.com>,
        Alex Deucher <alexander.deucher@....com>,
        linuxppc-dev@...ts.ozlabs.org,
        Christian König <christian.koenig@....com>
Subject: Re: [PATCH] powerpc: export cpu_smallcore_map for modules

On Mon, Aug 22, 2022 at 9:16 AM Christoph Hellwig <hch@...radead.org> wrote:
>
> On Mon, Aug 22, 2022 at 01:40:23PM +1000, Michael Ellerman wrote:
> > Randy Dunlap <rdunlap@...radead.org> writes:
> > > drivers/gpu/drm/amd/amdkfd/kfd_device.c calls cpu_smt_mask().
> > > This is an inline function on powerpc which references
> > > cpu_smallcore_map.
> > >
> > > Fixes: 425752c63b6f ("powerpc: Detect the presence of big-cores via "ibm, thread-groups"")
> > > Fixes: 7bc913085765 ("drm/amdkfd: Try to schedule bottom half on same core")
> >
> > That 2nd commit is not in mainline, only linux-next.
> >
> > I don't mind merging this fix preemptively, but is that SHA stable?
>
> I really do not think this has any business being exported at all.
>
> kfd_queue_work is not something that should be done in a driver.
> Something like this belongs into the workqueue core, not in an
> underdocumented helper in a random driver.
>
> Drm guys:  once again, please please work with the maintainers instead
> of just making up random stuff in the drivers.

Discussions are already ongoing with the workqueue folks.  I'll drop
this for now.

Alex