linux-kernel - Re: [PATCH] audit: Modifying indentation issue.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 22 Aug 2022 10:08:51 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     l00581214 <liutie4@...wei.com>
Cc:     eparis@...hat.com, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, hewenliang4@...wei.com,
        linfeilong@...wei.com
Subject: Re: [PATCH] audit: Modifying indentation issue.

On Fri, Jul 29, 2022 at 5:05 AM l00581214 <liutie4@...wei.com> wrote:
>
> From: Tie Liu <liutie4@...wei.com>
>
> Modifying indentation issue in audit_rate_check().
>
> Signed-off-by: Tie Liu <liutie4@...wei.com>
> ---
>  kernel/audit.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

While I agree that the style in this patch is preferable to the
existing style in the code, I'm growing weary of these minor style
change from developers who have not contributing any other meaningful
change to the audit subsystem.  Once you have established a history of
useful contributions to the audit subsystem feel free to (re)submit
this patch.

> diff --git a/kernel/audit.c b/kernel/audit.c
> index 7690c29d4..deeede166 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -324,7 +324,8 @@ static inline int audit_rate_check(void)
>         unsigned long           elapsed;
>         int                     retval     = 0;
>
> -       if (!audit_rate_limit) return 1;
> +       if (!audit_rate_limit)
> +               return 1;
>
>         spin_lock_irqsave(&lock, flags);
>         if (++messages < audit_rate_limit) {

-- 
paul-moore.com