linux-kernel - Re: [PATCH] perf metrics: Variable type completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YwOPfKRggard+jGh@kernel.org>
Date:   Mon, 22 Aug 2022 11:15:24 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Xin Gao <gaoxin@...rlc.com>
Cc:     peterz@...radead.org, mingo@...hat.com, namhyung@...nel.org,
        irogers@...gle.com, john.garry@...wei.com,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf metrics: Variable type completion

Em Wed, Aug 17, 2022 at 01:38:04AM +0800, Xin Gao escreveu:
> 'unsigned int' is better than 'unsigned'.

Thanks, applied.

- Arnaldo

 
> Signed-off-by: Xin Gao <gaoxin@...rlc.com>
> ---
>  tools/perf/util/metricgroup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
> index ee8fcfa115e5..8926de9617ef 100644
> --- a/tools/perf/util/metricgroup.c
> +++ b/tools/perf/util/metricgroup.c
> @@ -1620,7 +1620,7 @@ int metricgroup__copy_metric_events(struct evlist *evlist, struct cgroup *cgrp,
>  				    struct rblist *new_metric_events,
>  				    struct rblist *old_metric_events)
>  {
> -	unsigned i;
> +	unsigned int i;
>  
>  	for (i = 0; i < rblist__nr_entries(old_metric_events); i++) {
>  		struct rb_node *nd;
> -- 
> 2.30.2

-- 

- Arnaldo